Skip to content

Commit

Permalink
fix: encoding
Browse files Browse the repository at this point in the history
  • Loading branch information
jayzhang committed Nov 24, 2023
1 parent 592a460 commit 5881a58
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions packages/fx-core/src/component/driver/script/scriptDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ export async function executeCommand(
{
shell: finalShell,
cwd: workingDir,
encoding: "buffer",
env: { ...process.env, ...env },
timeout: timeout,
},
Expand All @@ -166,9 +167,9 @@ export async function executeCommand(
fs.appendFileSync(appendFile, data);
}
};
cp.stdout?.on("data", (data: any) => {
cp.stdout?.on("data", (data: Buffer) => {
const str = bufferToString(data, systemEncoding);
logProvider.info(` [script stdout] ${maskSecretValues(data)}`);
logProvider.info(` [script stdout] ${maskSecretValues(str)}`);
dataHandler(str);
});
const handler = getStderrHandler(logProvider, systemEncoding, stderrStrings, dataHandler);
Expand All @@ -180,7 +181,7 @@ export function getStderrHandler(
logProvider: LogProvider,
systemEncoding: string,
stderrStrings: string[],
dataHandler: (data: any) => void
dataHandler: (data: string) => void
): (data: Buffer) => void {
return (data: Buffer) => {
const str = bufferToString(data, systemEncoding);
Expand Down

0 comments on commit 5881a58

Please sign in to comment.