Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cli telemetry refinement #9594

Merged
merged 7 commits into from
Aug 11, 2023
Merged

refactor: cli telemetry refinement #9594

merged 7 commits into from
Aug 11, 2023

Conversation

jayzhang
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #9594 (b3cbe8e) into dev (5466052) will decrease coverage by 0.02%.
The diff coverage is 89.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #9594      +/-   ##
==========================================
- Coverage   84.65%   84.64%   -0.02%     
==========================================
  Files         450      450              
  Lines       25011    25040      +29     
  Branches     4696     4705       +9     
==========================================
+ Hits        21174    21196      +22     
- Misses       2092     2096       +4     
- Partials     1745     1748       +3     
Files Changed Coverage Δ
packages/cli/src/telemetry/cliTelemetry.ts 72.72% <ø> (-0.19%) ⬇️
packages/fx-core/src/core/FxCore.ts 79.27% <75.00%> (-0.82%) ⬇️
packages/cli/src/commands/engine.ts 73.62% <80.00%> (-0.22%) ⬇️
packages/cli/src/activate.ts 88.00% <100.00%> (+0.50%) ⬆️
packages/cli/src/commands/models/addSPFxWebpart.ts 100.00% <100.00%> (ø)
packages/cli/src/commands/models/create.ts 95.00% <100.00%> (ø)
packages/cli/src/commands/models/createSample.ts 94.73% <100.00%> (ø)
packages/cli/src/commands/models/deploy.ts 100.00% <100.00%> (ø)
packages/cli/src/commands/models/envAdd.ts 100.00% <100.00%> (ø)
packages/cli/src/commands/models/package.ts 100.00% <100.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Aug 11, 2023
@jayzhang jayzhang merged commit a99162f into dev Aug 11, 2023
18 of 19 checks passed
@jayzhang jayzhang deleted the huajie/cli-telemetry branch August 11, 2023 06:21
dooriya pushed a commit that referenced this pull request Aug 14, 2023
* feat: cli telemetry improvement

* feat: improve cli telemetry

* test: ut

* feat: revert

* test: ut

* test: ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs attention This issue needs the attention of a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants