Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Font-Weight Dance #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Font-Weight Dance #93

wants to merge 1 commit into from

Conversation

mitchellpalermo
Copy link

Added the font-weight dance according to the guidlines in the contribution file.

This is my first pull request, so please let me know if I've done something wrong or need to fix my code.

@Okazari
Copy link
Owner

Okazari commented Oct 11, 2018

Thanks for you submission ! Gonna review it when i got some free time in the incoming days :)

@Okazari
Copy link
Owner

Okazari commented Oct 28, 2018

Hey. Sorry for the delay. I've been really busy theses days. Gonna give it a look asap to merge it before the end of the month

Copy link
Owner

@Okazari Okazari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the documentation of your dance in readme ? And an example in example.js/index.html ?

Code LGTM. Gonna test it asap.

@Okazari Okazari mentioned this pull request Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants