Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix IAM test carryover #1090

Merged
merged 1 commit into from
May 19, 2022
Merged

[Tests] Fix IAM test carryover #1090

merged 1 commit into from
May 19, 2022

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented May 19, 2022

Description

One Line Summary

Fix test testSetLanguage_afterOnSession hanging due to an issue with InAppMessagingTests not cleaning up it's state.

Details

Motivation

This issue caused tests to stall so the full suite couldn't be run before.

Scope

Only tests affected.

Testing

Manual testing

Ran tests on Xcode 13.3.1.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes
  • Tests

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

This was causing the next test, testSetLanguage_afterOnSession in this
case, to hang due to a playerId nil issue with IAMs.
@jkasten2 jkasten2 requested review from emawby, nan-li and a team May 19, 2022 02:44
Base automatically changed from test/add_back_to_xcode_proj to main May 19, 2022 17:12
@jkasten2 jkasten2 merged commit 45b1974 into main May 19, 2022
@jkasten2 jkasten2 deleted the test/fix_iam_test_carryover branch May 19, 2022 17:12
@emawby emawby mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants