[Fix] swizzle of deprecated didReceiveRemoteNotification #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While didReceiveRemoteNotification has been deprecated for a while there may still be some older apps still expecting this to be called and OneSignal should not cause any side effects. Apple's iOS logic is both didReceiveRemoteNotification and didReceiveRemoteNotification:fetchCompletionHandler are defined only the newer API will be called. This means OneSignal must also replicate this logic to prevent side effects. https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623117-application?language=objc Also removed our swizzling on didReceiveRemoteNotification as we no longer support iOS 6. Apple added application:didReceiveRemoteNotification:fetchCompletionHandler: in iOS 7 so we could have dropped this swizzling awhile ago.
jkasten2
changed the title
emawby
approved these changes
May 25, 2022
jkasten2
deleted the
fix/swizzle_forwarding_deprecated_didReceiveRemoteNotification
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix
application:didReceiveRemoteNotification:not being called on iOS 10+, due to OneSignal addingapplication:didReceiveRemoteNotification:fetchCompletionHandler:.Details
Motivation
This is a long standing bug on a very deprecated selector, however OneSignal should not cause any side effects when possible. Priority was put resolving shortly after discovering as it is easier to address while it fresh in the mind of those who are working on some unrelated but recent swizzling fixes.
Scope
Only effects apps that use
application:didReceiveRemoteNotification:but uses none of the other notification selectors in theirAppDelegateAND also have not setup their ownUNUserNotificationCenterDelegate.Clean up
Also in this PR is cleaning up
oneSignalReceivedRemoteNotification, since it was only required to support iOS 6 and older.Testing
Unit testing
Added a new test.
Manual testing
Tested on an iPhone 6s with iOS 14.4.1. Tested with both a SwiftUI app and Objective-C app.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is