Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swiftlint to CI.yml #1122

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Add swiftlint to CI.yml #1122

merged 1 commit into from
Aug 30, 2022

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Aug 29, 2022

Description

One Line Summary

running swiftlint in ci.yml for prs

Details

swiftlint will only error for serious violations, but will log warnings or smaller violations. The rules can be configured with .swiftlint.yml in the root directory.

Note that this only analyzes Swift files.

Motivation

linting for PRs

Scope

ci.yml action and Package.swift

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes
  • Release process

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby changed the title install and run swiftlint on the OneSignalSDK folder WiP install and run swiftlint on the OneSignalSDK folder Aug 29, 2022
Fixing lint issues with Package.swift and setting line length warning
to 150
@emawby emawby changed the title WiP install and run swiftlint on the OneSignalSDK folder Add swiftlint to CI.yml Aug 30, 2022
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fhboswell and @nan-li)

@emawby emawby merged commit 491902f into main Aug 30, 2022
@emawby emawby deleted the add_swift_lint branch August 30, 2022 18:03
@emawby emawby mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants