add migration for alerts

OneUptime · Oct 2, 2024 · b624bd4 · b624bd4
1 parent 249a9d9
commit b624bd4
Show file tree

Hide file tree

Showing 12 changed files with 599 additions and 72 deletions.
diff --git a/Common/Server/Infrastructure/Postgres/SchemaMigrations/1727906598804-MigrationName.ts b/Common/Server/Infrastructure/Postgres/SchemaMigrations/1727906598804-MigrationName.ts
diff --git a/Common/Server/Infrastructure/Postgres/SchemaMigrations/Index.ts b/Common/Server/Infrastructure/Postgres/SchemaMigrations/Index.ts
@@ -72,6 +72,7 @@ import { MigrationName1727193702212 } from "./1727193702212-MigrationName";
 import { MigrationName1727194211048 } from "./1727194211048-MigrationName";
 import { MigrationName1727194579925 } from "./1727194579925-MigrationName";
 import { MigrationName1727894983857 } from "./1727894983857-MigrationName";
+import { MigrationName1727906598804 } from "./1727906598804-MigrationName";
 
 export default [
   InitialMigration,
@@ -148,4 +149,5 @@ export default [
   MigrationName1727194211048,
   MigrationName1727194579925,
   MigrationName1727894983857,
+  MigrationName1727906598804,
 ];
diff --git a/Common/Types/Email/EmailTemplateType.ts b/Common/Types/Email/EmailTemplateType.ts
@@ -31,12 +31,11 @@ enum EmailTemplateType {
   IncidentOwnerNotePosted = "IncidentOwnerNotePosted.hbs",
   IncidentOwnerResourceCreated = "IncidentOwnerResourceCreated.hbs",
 
-
   AlertOwnerAdded = "AlertOwnerAdded.hbs",
   AlertOwnerStateChanged = "AlertOwnerStateChanged.hbs",
   AlertOwnerNotePosted = "AlertOwnerNotePosted.hbs",
   AlertOwnerResourceCreated = "AlertOwnerResourceCreated.hbs",
-  
+
   ScheduledMaintenanceOwnerNotePosted = "ScheduledMaintenanceOwnerNotePosted.hbs",
   ScheduledMaintenanceOwnerAdded = "ScheduledMaintenanceOwnerAdded.hbs",
   ScheduledMaintenanceOwnerStateChanged = "ScheduledMaintenanceOwnerStateChanged.hbs",

diff --git a/Common/Types/Monitor/MonitorCriteriaInstance.ts b/Common/Types/Monitor/MonitorCriteriaInstance.ts
@@ -25,7 +25,7 @@ export interface MonitorCriteriaInstanceType {
   description: string;
   changeMonitorStatus?: boolean | undefined;
   createIncidents?: boolean | undefined;
-  createAlerts?: boolean | undefined; 
+  createAlerts?: boolean | undefined;
   id: string;
 }
 
@@ -46,7 +46,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
         },
       ],
       createIncidents: false,
-      createAlerts: false, 
+      createAlerts: false,
       changeMonitorStatus: false,
       incidents: [],
       alerts: [],
@@ -77,7 +77,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
         ],
         incidents: [],
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         changeMonitorStatus: true,
         createIncidents: false,
         name: `Check if ${arg.monitorName} is online`,
@@ -106,7 +106,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
         alerts: [],
         changeMonitorStatus: true,
         createIncidents: false,
-        createAlerts: false, 
+        createAlerts: false,
         name: `Check if ${arg.monitorName} is online`,
         description: `This criteria checks if the ${arg.monitorName} is online`,
       };
@@ -130,8 +130,8 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
           },
         ],
         incidents: [],
-        alerts: [], 
-        createAlerts: false, 
+        alerts: [],
+        createAlerts: false,
         changeMonitorStatus: true,
         createIncidents: false,
         name: `Check if ${arg.monitorName} is online`,
@@ -158,7 +158,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
         ],
         incidents: [],
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         changeMonitorStatus: true,
         createIncidents: false,
         name: `Check if ${arg.monitorName} is online`,
@@ -187,7 +187,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
           },
         ],
         incidents: [],
-        alerts: [], 
+        alerts: [],
         createAlerts: false,
         changeMonitorStatus: true,
         createIncidents: false,
@@ -215,7 +215,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
         ],
         incidents: [],
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         changeMonitorStatus: true,
         createIncidents: false,
         name: `Check if ${arg.monitorName} is online`,
@@ -248,7 +248,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
         ],
         incidents: [],
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         changeMonitorStatus: true,
         createIncidents: false,
         name: `Check if ${arg.monitorName} is online`,
@@ -310,7 +310,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
         ],
         changeMonitorStatus: true,
         createIncidents: true,
-        createAlerts: false, 
+        createAlerts: false,
         alerts: [],
         name: `Check if ${arg.monitorName} is offline`,
         description: `This criteria checks if the ${arg.monitorName} is offline`,
@@ -338,7 +338,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
           },
         ],
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         incidents: [
           {
             title: `${arg.monitorName} is offline`,
@@ -379,7 +379,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
           },
         ],
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         changeMonitorStatus: true,
         createIncidents: true,
         name: `Check if ${arg.monitorName} is offline`,
@@ -400,7 +400,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
           },
         ],
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         incidents: [
           {
             title: `${arg.monitorName} is offline`,
@@ -431,7 +431,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
           },
         ],
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         incidents: [
           {
             title: `${arg.monitorName} is offline`,
@@ -465,7 +465,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
           },
         ],
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         incidents: [
           {
             title: `${arg.monitorName} is offline`,
@@ -489,7 +489,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
         monitorStatusId: arg.monitorStatusId,
         filterCondition: FilterCondition.Any,
         alerts: [],
-        createAlerts: false, 
+        createAlerts: false,
         filters: [
           {
             checkOn: CheckOn.IsNotAValidCertificate,
@@ -659,10 +659,7 @@ export default class MonitorCriteriaInstance extends DatabaseProperty {
     return this;
   }
 
-
-  public setAlerts(
-    alerts: Array<CriteriaAlert>,
-  ): MonitorCriteriaInstance {
+  public setAlerts(alerts: Array<CriteriaAlert>): MonitorCriteriaInstance {
     if (this.data) {
       this.data.alerts = [...alerts];
     }

diff --git a/Dashboard/src/Components/Form/Monitor/MonitorCriteriaAlertsForm.tsx b/Dashboard/src/Components/Form/Monitor/MonitorCriteriaAlertsForm.tsx
@@ -37,9 +37,7 @@ const MonitorCriteriaAlertsForm: FunctionComponent<ComponentProps> = (
         return (
           <MonitorCriteriaAlertForm
             key={index}
-            alertSeverityDropdownOptions={
-              props.alertSeverityDropdownOptions
-            }
+            alertSeverityDropdownOptions={props.alertSeverityDropdownOptions}
             onCallPolicyDropdownOptions={props.onCallPolicyDropdownOptions}
             initialValue={i}
             // onDelete={() => {

diff --git a/Dashboard/src/Components/Form/Monitor/MonitorCriteriaInstance.tsx b/Dashboard/src/Components/Form/Monitor/MonitorCriteriaInstance.tsx
@@ -91,7 +91,6 @@ const MonitorCriteriaInstanceElement: FunctionComponent<ComponentProps> = (
     (props.initialValue?.data?.incidents?.length || 0) > 0,
   );
 
-
   const [showAlertControl, setShowAlertControl] = useState<boolean>(
     (props.initialValue?.data?.alerts?.length || 0) > 0,
   );
@@ -293,9 +292,7 @@ const MonitorCriteriaInstanceElement: FunctionComponent<ComponentProps> = (
         </div>
       )}
 
-
-
-<div className="mt-4">
+      <div className="mt-4">
         <Toggle
           value={showAlertControl}
           title="When filters match, create an alert."
@@ -333,9 +330,7 @@ const MonitorCriteriaInstanceElement: FunctionComponent<ComponentProps> = (
 
           <MonitorCriteriaAlertsForm
             initialValue={monitorCriteriaInstance?.data?.alerts || []}
-            alertSeverityDropdownOptions={
-              props.alertSeverityDropdownOptions
-            }
+            alertSeverityDropdownOptions={props.alertSeverityDropdownOptions}
             onCallPolicyDropdownOptions={props.onCallPolicyDropdownOptions}
             onChange={(value: Array<CriteriaAlert>) => {
               monitorCriteriaInstance.setAlerts(value);

diff --git a/Dashboard/src/Components/Form/Monitor/MonitorSteps.tsx b/Dashboard/src/Components/Form/Monitor/MonitorSteps.tsx
@@ -40,8 +40,7 @@ const MonitorStepsElement: FunctionComponent<ComponentProps> = (
   const [incidentSeverityDropdownOptions, setIncidentSeverityDropdownOptions] =
     React.useState<Array<DropdownOption>>([]);
 
-
-    const [alertSeverityDropdownOptions, setAlertSeverityDropdownOptions] =
+  const [alertSeverityDropdownOptions, setAlertSeverityDropdownOptions] =
     React.useState<Array<DropdownOption>>([]);
 
   const [onCallPolicyDropdownOptions, setOnCallPolicyDropdownOptions] =
@@ -99,8 +98,7 @@ const MonitorStepsElement: FunctionComponent<ComponentProps> = (
           },
         });
 
-
-        const alertSeverityList: ListResult<AlertSeverity> =
+      const alertSeverityList: ListResult<AlertSeverity> =
         await ModelAPI.getList({
           modelType: AlertSeverity,
           query: {},
@@ -138,7 +136,6 @@ const MonitorStepsElement: FunctionComponent<ComponentProps> = (
         );
       }
 
-
       if (alertSeverityList.data) {
         setAlertSeverityDropdownOptions(
           alertSeverityList.data.map((i: AlertSeverity) => {
@@ -184,7 +181,7 @@ const MonitorStepsElement: FunctionComponent<ComponentProps> = (
               },
             )!.id!,
             defaultIncidentSeverityId: incidentSeverityList.data[0]!.id!,
-            defaultAlertSeverityId: alertSeverityList.data[0]!.id!
+            defaultAlertSeverityId: alertSeverityList.data[0]!.id!,
           }),
         );
       }

diff --git a/Worker/Jobs/AlertOwners/SendCreatedResourceNotification.ts b/Worker/Jobs/AlertOwners/SendCreatedResourceNotification.ts
@@ -117,8 +117,7 @@ RunCron(
               alert.description! || "",
               MarkdownContentType.Email,
             ),
-            resourcesAffected:
-              alert.monitor?.name || "None",
+            resourcesAffected: alert.monitor?.name || "None",
             alertSeverity: alert.alertSeverity!.name!,
             declaredAt: OneUptimeDate.getDateAsFormattedHTMLInMultipleTimezones(
               {
@@ -134,8 +133,7 @@ RunCron(
               )) || "",
             rootCause:
               (await Markdown.convertToHTML(
-                alert.rootCause ||
-                  "No root cause identified for this alert",
+                alert.rootCause || "No root cause identified for this alert",
                 MarkdownContentType.Email,
               )) || "",
             alertViewLink: (
@@ -178,9 +176,7 @@ RunCron(
               NotificationSettingEventType.SEND_INCIDENT_CREATED_OWNER_NOTIFICATION,
           });
         } catch (e) {
-          logger.error(
-            "Error in sending alert created resource notification",
-          );
+          logger.error("Error in sending alert created resource notification");
           logger.error(e);
         }
       }

diff --git a/Worker/Jobs/AlertOwners/SendNotePostedNotification.ts b/Worker/Jobs/AlertOwners/SendNotePostedNotification.ts
@@ -22,7 +22,6 @@ RunCron(
   "AlertOwner:SendsNotePostedEmail",
   { schedule: EVERY_MINUTE, runOnStartup: false },
   async () => {
-
     const privateNotes: Array<AlertInternalNote> =
       await AlertInternalNoteService.findBy({
         query: {
@@ -47,7 +46,6 @@ RunCron(
       },
     );
 
-
     for (const note of privateNotes) {
       await AlertInternalNoteService.updateOneById({
         id: note.id!,
@@ -60,7 +58,7 @@ RunCron(
       });
     }
 
-    const notes: Array<BaseModel> = [ ...privateNotes];
+    const notes: Array<BaseModel> = [...privateNotes];
 
     for (const noteObject of notes) {
       const note: BaseModel = noteObject as BaseModel;
@@ -124,8 +122,7 @@ RunCron(
           (note.getColumnValue("note")! as string) || "",
           MarkdownContentType.Email,
         ),
-        resourcesAffected:
-          alert.monitor?.name || "None",
+        resourcesAffected: alert.monitor?.name || "None",
         alertSeverity: alert.alertSeverity!.name!,
         alertViewLink: (
           await AlertService.getAlertLinkInDashboard(

diff --git a/Worker/Jobs/AlertOwners/SendOwnerAddedNotification.ts b/Worker/Jobs/AlertOwners/SendOwnerAddedNotification.ts
@@ -165,8 +165,7 @@ RunCron(
           alert.description! || "",
           MarkdownContentType.Email,
         ),
-        resourcesAffected:
-          alert.monitor?.name || "None",
+        resourcesAffected: alert.monitor?.name || "None",
         alertSeverity: alert.alertSeverity!.name!,
         alertViewLink: (
           await AlertService.getAlertLinkInDashboard(

diff --git a/Worker/Jobs/AlertOwners/SendStateChangeNotification.ts b/Worker/Jobs/AlertOwners/SendStateChangeNotification.ts
@@ -81,19 +81,18 @@ RunCron(
       const alertState: AlertState = alertStateTimeline.alertState!;
 
       // get alert severity
-      const alertWithSeverity: Alert | null =
-        await AlertService.findOneById({
-          id: alert.id!,
-          props: {
-            isRoot: true,
-          },
-          select: {
-            _id: true,
-            alertSeverity: {
-              name: true,
-            },
+      const alertWithSeverity: Alert | null = await AlertService.findOneById({
+        id: alert.id!,
+        props: {
+          isRoot: true,
+        },
+        select: {
+          _id: true,
+          alertSeverity: {
+            name: true,
           },
-        });
+        },
+      });
 
       if (!alertWithSeverity) {
         continue;
@@ -119,9 +118,7 @@ RunCron(
         doesResourceHasOwners = false;
 
         // find project owners.
-        owners = await ProjectService.getOwners(
-          alertStateTimeline.projectId!,
-        );
+        owners = await ProjectService.getOwners(alertStateTimeline.projectId!);
       }
 
       if (owners.length === 0) {
@@ -137,9 +134,7 @@ RunCron(
             alert.description! || "",
             MarkdownContentType.Email,
           ),
-          resourcesAffected:
-            alert
-              .monitor?.name || "",
+          resourcesAffected: alert.monitor?.name || "",
           stateChangedAt:
             OneUptimeDate.getDateAsFormattedHTMLInMultipleTimezones({
               date: alertStateTimeline.createdAt!,