Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector cube usage in aggregate_spatial, filter_spatial, mask_polygon, ... #323

Closed
soxofaan opened this issue Feb 15, 2022 · 3 comments · Fixed by #382
Closed

Vector cube usage in aggregate_spatial, filter_spatial, mask_polygon, ... #323

soxofaan opened this issue Feb 15, 2022 · 3 comments · Fixed by #382
Assignees
Milestone

Comments

@soxofaan
Copy link
Member

soxofaan commented Feb 15, 2022

Processes aggregate_spatial, filter_spatial, mask_polygon have a geometries (or mask) parameter that currently is of type geojson:object. Likewise, load_collection and load_result have a spatial_extent parameter that can be geojson:object (among other options).

Once we improve support for loading/processing vector cubes (e.g. #322) these processes should also allow vector-cube as data type for these parameters,
so that a user can pass the geometries with a file/url instead of embedding geojson in the process graph

@soxofaan soxofaan changed the title Vector cube usage in aggregate_spatial, filter_spatial, mask_polygon Vector cube usage in aggregate_spatial, filter_spatial, mask_polygon, ... Feb 15, 2022
@m-mohr
Copy link
Member

m-mohr commented Feb 15, 2022

Yes, that's on the todo list for sure.

@m-mohr m-mohr self-assigned this Feb 15, 2022
@clausmichele
Copy link
Member

Allowing aggregate_spatial to get vector-cube as input is necessary to proceed with the random_forest pipeline. In the meanwhile I will modify the process locally for some tests.
image

@m-mohr
Copy link
Member

m-mohr commented Mar 15, 2022

Closely related: #343 and #346

I'm not sure I'd add vector-cube as input for load_result and load_collection. These are compromises of simplicity and utility.
You may then just add it to filter_spatial as a dedicated process that can be used to filter based on vector cubes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants