Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep/add or deprecate GeoJSON input type? #343

Closed
m-mohr opened this issue Mar 15, 2022 · 6 comments · Fixed by #412
Closed

Keep/add or deprecate GeoJSON input type? #343

m-mohr opened this issue Mar 15, 2022 · 6 comments · Fixed by #412
Labels
must-have question Further information is requested vector
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Mar 15, 2022

With the introduction of vector data cubes there's the question whether the geojson type should still be used and added in vector processes or not.

Options:

  1. Keep GeoJSON Schema in existing processes and add to new processes
  2. Deprecate GeoJSON schema in existing processes and don't add GeoJSON schema to new processes. Then we'd want to add a new process to load/convert GeoJSON to a vector cube (see process to convert inline GeoJSON to a vector cube #346 ).

I'm not sure what I prefer. In processes, it could be easier to not have it, in (my) tooling/implementations it is probably a bit easier to have it.

Origin: https://github.com/Open-EO/openeo-processes/pull/315/files#r814788548

Closely related to #323

@m-mohr m-mohr added the vector label Mar 15, 2022
@m-mohr m-mohr added this to the 1.3.0 milestone Mar 15, 2022
@m-mohr m-mohr self-assigned this Mar 15, 2022
@m-mohr m-mohr added the question Further information is requested label Mar 15, 2022
@m-mohr
Copy link
Member Author

m-mohr commented Mar 15, 2022

The more I'm thinking about this the more I'm leaning towards option 2...

@soxofaan
Copy link
Member

yes, imagine that everywhere where you can now pass a raster cube, you would also be able to pass a multi-dimensional array construct like [[[1,2,3], [4,5,6], ...

@m-mohr
Copy link
Member Author

m-mohr commented Mar 15, 2022

Also, there are not a lot of processes affected by the deprecation. I'm only sure we'd deprecate in aggregate_spatial. I'm not sure about filter_spatial and mask_polygon.

@clausmichele
Copy link
Member

By the way, for UC8 I think that we'll use the old geoJSON spec, which allows different projections specifying the "crs" value.
Therefore, this geoJSON will be directly passed to fit_regr_random_forest in the process graph.

This can be replaced by a load_vector_cube process once it will be ready.

@m-mohr
Copy link
Member Author

m-mohr commented Mar 15, 2022

I'll try to draft a process soon as this would indeed make other process descriptions easier.

@m-mohr m-mohr modified the milestones: 1.3.0, 2.0.0 Feb 1, 2023
@m-mohr m-mohr linked a pull request Mar 8, 2023 that will close this issue
@m-mohr
Copy link
Member Author

m-mohr commented Mar 8, 2023

Draft proposal available in PR #412.

@m-mohr m-mohr removed their assignment Mar 14, 2023
@m-mohr m-mohr closed this as completed Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must-have question Further information is requested vector
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants