Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit_class_random_forest: process should return training and validation accuracy #354

Closed
JeroenVerstraelen opened this issue Mar 23, 2022 · 3 comments · Fixed by #351
Closed
Milestone

Comments

@JeroenVerstraelen
Copy link

Describe the issue:
The fit_class_random_forest process requires a training parameter which a back-end uses to split the data in a training and validation set. However, there is no description for what should be done with this validation set.

Proposed solution:
Return the training and validation accuracy perhaps as part of the STAC ml-model extension. This allows the user to fine-tune the hyper-parameters based on these values.

@m-mohr
Copy link
Member

m-mohr commented Mar 23, 2022

Yes, I think we should create a PR for the ml-model extension to support this. Once that is done we can clarify this in the process, too. Would you be up to work (with me?) on a ml-model PR?

@m-mohr m-mohr added this to the 1.3.0 milestone Mar 23, 2022
@jdries
Copy link
Contributor

jdries commented Mar 23, 2022

Dev telco conclusion: drop training/validation split

m-mohr added a commit that referenced this issue Mar 23, 2022
@m-mohr m-mohr linked a pull request Mar 23, 2022 that will close this issue
@m-mohr
Copy link
Member

m-mohr commented Mar 23, 2022

@JeroenVerstraelen @jdries Please review PR #351

@m-mohr m-mohr closed this as completed Mar 24, 2022
soxofaan added a commit to Open-EO/openeo-python-client that referenced this issue Mar 29, 2022
soxofaan added a commit to Open-EO/openeo-python-driver that referenced this issue Mar 29, 2022
@m-mohr m-mohr modified the milestones: 1.3.0, 2.0.0 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants