Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge_cubes: resample implicitly #402

Closed
m-mohr opened this issue Feb 1, 2023 · 1 comment · Fixed by #405
Closed

merge_cubes: resample implicitly #402

m-mohr opened this issue Feb 1, 2023 · 1 comment · Fixed by #405
Assignees
@m-mohr
Labels
minor
Milestone
2.0.0

Comments

@m-mohr
Copy link
Member

m-mohr commented Feb 1, 2023 •
edited
Loading

Process ID: merge_cubes

Describe the issue:

@jdries wrote at https://discuss.eodc.eu/t/terrascope-backend-upgrade/542:

merge_cubes and mask will now try to automatically resample input data cubes if required, reducing the need to always use resample_cube_spatial
When catalogs contain 2 versions of the same product, we now detect this better and try to use the most recent version. This improves performance, but also reproducibility.

This is not ideal wrt reproducibility, I think. Different back-ends behave differently then.
It's non breaking as it purely adds behavior for what before just threw an error.

Proposed solution:

We discussed this in the PSC and it seems reasonable here to be user-friendly and implicitly add the resampling to the merge_cubes process in general. It would be described just as an implicit call to resample_cube_spatial where the first cube is always the baseline.
@m-mohr m-mohr added the minor label Feb 1, 2023
@m-mohr m-mohr added this to the 1.3.0 milestone Feb 1, 2023
@m-mohr m-mohr self-assigned this Feb 1, 2023
@m-mohr m-mohr modified the milestones: 1.3.0, 2.0.0 Feb 1, 2023
@soxofaan soxofaan mentioned this issue Feb 3, 2023
Closed
@soxofaan
Copy link
Member

soxofaan commented Feb 3, 2023 •
edited
Loading

This feature could also be considered for the mask process

m-mohr added a commit that referenced this issue Feb 3, 2023
@m-mohr
mask and merge_cubes: The spatial dimensions x and y can now …
4d4a5bf 
…be resampled implicitly instead of throwing an error. #402
@m-mohr m-mohr mentioned this issue Feb 3, 2023
Merged
m-mohr added a commit that referenced this issue Feb 3, 2023
@m-mohr
mask and merge_cubes: The spatial dimensions x and y can now …
2a0cab9 
…be resampled implicitly instead of throwing an error. #402
@m-mohr m-mohr linked a pull request Feb 3, 2023 that will close this issue
Implicit resampling for spatial dimensions in mask and merge_cubes + clarifications #405
Merged
@m-mohr m-mohr mentioned this issue Mar 14, 2023
Closed
m-mohr added a commit that referenced this issue Mar 14, 2023
@m-mohr
Implicit resampling for spatial dimensions in mask and merge_cubes + …
08cb18d 
…clarifications (#405)

* `mask` and `merge_cubes`: The spatial dimensions `x` and `y` can now be resampled implicitly instead of throwing an error. #402

* Clarify descriptions #379

* Improve wording as suggested by @soxofaan

* Update merge_cubes.json

* Slim down description

* Default parameters of resample_cube_spatial apply
@m-mohr m-mohr closed this as completed Mar 14, 2023
This was referenced May 4, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-mohr m-mohr

Labels
minor
Projects
None yet
Milestone
2.0.0
2 participants
@soxofaan @m-mohr