Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregate_spatial_window #192

Merged
merged 17 commits into from
Sep 22, 2020
Merged

Add aggregate_spatial_window #192

merged 17 commits into from
Sep 22, 2020

Conversation

clausmichele
Copy link
Member

I created a new pull request from draft to draft, with the corrected json file, which now should be correctly formatted. Let's continue the discussion here.

@m-mohr m-mohr changed the title Add aggregate_spatial_window to draft Add aggregate_spatial_window Sep 17, 2020
Copy link
Member

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of detailed review comments. After working on the comments, have a look at the CI results (currently fails) and change the JSON file accordingly, please.

aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
"parameters": [
{
"name": "data",
"description": "A raster data cube.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have constraints? It seems like the input raster data cube must have only two dimensions? x and y...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the implementation I am working on, it just needs to have x and y, if it is a timeseries then it will be applied on the full timeseries and return another timeseries. So the datacube dimensions could be (time,x,y) or (x,y) or (band,x,y) or (time,band,x,y) and so on. But we can also choose to limit it to 2d datacubes to ease the implementation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss later in the meeting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs clarification

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about:
"description": "A raster data cube with two spatial dimensions and arbitrary number of bands and times. If the datacube has multiple bands the process will be applied to all of them. Same for a timeseries."

Sorry I'm not good in writing this kind of descriptions.

aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
clausmichele and others added 5 commits September 17, 2020 11:41
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@clausmichele
Copy link
Member Author

I don't know why the build fails, it tells me that the word 'behavior' is misspelled

@m-mohr
Copy link
Member

m-mohr commented Sep 22, 2020

@clausmichele I guess it wants you to use 'behaviour'. Other than that it's failing because the JSON needs to be formatted with 4 spaces. Running the JSON through https://jsonformatter.org/ with 4 Tab Spaces should make it work.

Behaviour (UK) instead of behavior (US)
aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
"parameters": [
{
"name": "data",
"description": "A raster data cube.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs clarification

aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
aggregate_spatial_window.json Outdated Show resolved Hide resolved
clausmichele and others added 4 commits September 22, 2020 10:40
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@m-mohr m-mohr changed the base branch from draft to proposals September 22, 2020 09:02
@m-mohr
Copy link
Member

m-mohr commented Sep 22, 2020

I completely lost track in this PR of what still needs to be done. Too many comments and commits. Let's merge this into a new branch here and make a new PR for more detailed discussions that then merges into draft.

@m-mohr m-mohr merged commit 66c5f78 into Open-EO:proposals Sep 22, 2020
jdries pushed a commit that referenced this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants