Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse array_find #291

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Reverse array_find #291

merged 4 commits into from
Nov 4, 2021

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Oct 25, 2021

Implements #269

@m-mohr m-mohr added the minor label Oct 25, 2021
@m-mohr m-mohr added this to the 1.2.0 milestone Oct 25, 2021
@m-mohr m-mohr linked an issue Oct 25, 2021 that may be closed by this pull request
Reverse array_find #269
Closed
soxofaan
soxofaan reviewed Oct 28, 2021
View reviewed changes
array_find.json Outdated Show resolved Hide resolved
array_find.json Outdated Show resolved Hide resolved
@m-mohr m-mohr requested a review from soxofaan October 28, 2021 16:16
soxofaan
soxofaan approved these changes Nov 4, 2021
View reviewed changes
array_find.json Outdated Show resolved Hide resolved
@soxofaan
Copy link
Member

soxofaan commented Nov 4, 2021

FYI: I approved, except for the note about swapping value and returns in the example

@m-mohr m-mohr merged commit 6b666e6 into draft Nov 4, 2021
@m-mohr m-mohr deleted the issue-269 branch November 4, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan soxofaan approved these changes

@Bart92 Bart92 Awaiting requested review from Bart92

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Reverse array_find
2 participants
@m-mohr @soxofaan