quantiles: Deprecate q in favor of probabilities #293 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metzm
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
I tend to prefer two different options, but in this case there are good arguments to avoid two different options which would be mutually exclusive, at the same time one of them is required, and the two different meanings (probabilities or number of intervals) are very easy to distinguish.
# Conflicts: # CHANGELOG.md # quantiles.json
m-mohr
requested review from
LukeWeidenwalker,
dthiex and
mkadunc
and removed request for
SerRichard
mkadunc
approved these changes
Mar 14, 2023
soxofaan
reviewed
Mar 16, 2023
LukeWeidenwalker
approved these changes
Mar 16, 2023
dthiex
approved these changes
Mar 21, 2023
soxofaan
approved these changes
Mar 30, 2023
This was referenced May 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293