Improve support for labeled arrays in experimental array processes #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…discarded them. Should help with #233.
m-mohr
force-pushed
the
labeled-arrays
branch
from
c8548cd
to
3aecbc0
Compare
soxofaan
reviewed
Jan 6, 2022
soxofaan
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added better support for labeled arrays in experimental array processes that previously simply discarded the labels. Affected processes:
array_appendarray_concatarray_modifyThe idea is that this will help overall to improve support for labeled arrays and get a better solution for #233, e.g. through a modified version of
apply_dimension(as discussed with @clausmichele).