Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math functions: Clarified value ranges and NaN #476

Merged
merged 13 commits into from
Dec 8, 2023
Merged

Math functions: Clarified value ranges and NaN #476

merged 13 commits into from
Dec 8, 2023

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Oct 24, 2023

Related to #468

arccos.json Show resolved Hide resolved
artanh.json Show resolved Hide resolved
arcsin.json Show resolved Hide resolved
…tput ranges. Mention that `NaN` is returned outside of the defined input range where possible.
@m-mohr m-mohr requested a review from soxofaan October 26, 2023 18:55
@m-mohr m-mohr changed the title Trigonometric functions: Clarified value ranges and NaN Math functions: Clarified value ranges and NaN Oct 26, 2023
Copy link
Member

@clausmichele clausmichele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some functions would allow extended ranges once we will support complex numbers. For the time being I think it's fine.

Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more notes

arcosh.json Outdated Show resolved Hide resolved
arcosh.json Outdated Show resolved Hide resolved
artanh.json Outdated Show resolved Hide resolved
cosh.json Show resolved Hide resolved
tan.json Outdated Show resolved Hide resolved
@m-mohr m-mohr requested a review from soxofaan October 27, 2023 10:13
# Conflicts:
#	CHANGELOG.md
#	ln.json
#	log.json
@m-mohr
Copy link
Member Author

m-mohr commented Oct 27, 2023

Merged #473 into this PR due to the large overlap of changes.

@m-mohr m-mohr merged commit ad8a2f3 into draft Dec 8, 2023
2 checks passed
@m-mohr m-mohr deleted the trigonometric branch December 8, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants