Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array_interpolate_linear: Apply interpolation to NaN values #479

Closed
wants to merge 2 commits into from

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Oct 30, 2023

No description provided.

@m-mohr m-mohr added this to the 2.0.0 milestone Oct 30, 2023
@m-mohr m-mohr changed the title array_interpolate_linear: Apply interpolation also on NaN values. array_interpolate_linear: Apply interpolation to NaN values Oct 30, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@clausmichele
Copy link
Member

Do we need two types: no-data and NaN ?

@m-mohr
Copy link
Member Author

m-mohr commented Oct 30, 2023

They are pretty much the same in the context of openEO. null is just a generic abstraction of a no-data value, which could be NaN. But maybe we should have a broader discussion about it now that it's getting more relevant...

@m-mohr m-mohr mentioned this pull request Oct 31, 2023
@m-mohr
Copy link
Member Author

m-mohr commented Oct 31, 2023

Opened #480 to discuss null vs NaN

@m-mohr
Copy link
Member Author

m-mohr commented Dec 8, 2023

After the recent discussions, I think this PR is fine as it is. The aim for this process is to fill "holes" in the data and both NaN and any additional no-data values that may apply should be filled.

@m-mohr
Copy link
Member Author

m-mohr commented Jan 3, 2024

Closing in favor of #490

@m-mohr m-mohr closed this Jan 3, 2024
@m-mohr m-mohr deleted the interpolate-nan branch January 3, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants