Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not auto-add save_result when export_workspace is used #623

Closed
jdries opened this issue Sep 20, 2024 · 3 comments
Closed

do not auto-add save_result when export_workspace is used #623

jdries opened this issue Sep 20, 2024 · 3 comments
Assignees
@soxofaan
Labels
technical debt

Comments

@jdries
Copy link
Collaborator

jdries commented Sep 20, 2024 •
edited
Loading

Current behaviour:

openeo-python-client/openeo/rest/datacube.py

Line 2079 in 29ae888

if result_node.process_id == "save_result":

If last node is not save_result, then add it automatically.

Better: check the entire graph for save_result processes? If there are any, then the user probably knows what he's doing.
@soxofaan
Copy link
Member

Indeed, there is quite some technical debt to clean up around "save_result" handling. Related tickets:

soxofaan added a commit that referenced this issue Sep 24, 2024
@soxofaan
Improve auto-adding of save_result (#623, #401, #583, #391)
5aa28fb 
- Check whole process graph for pre-existing `save_result` nodes, not just final node
- Disallow ambiguity of combining explicit `save_result` and download/create_job with format
@soxofaan soxofaan mentioned this issue Sep 24, 2024
Closed
@soxofaan
Copy link
Member

started working on draft at #630

soxofaan added a commit that referenced this issue Sep 25, 2024
@soxofaan
fixup! Improve auto-adding of save_result (#623, #401, #583, #391)
a95d73f
soxofaan added a commit that referenced this issue Sep 25, 2024
@soxofaan
fixup! fixup! Improve auto-adding of save_result (#623, #401, #583, #391
9478ea1 
)
soxofaan added a commit that referenced this issue Sep 25, 2024
@soxofaan
PR #630 better "weak" format handling in execute_batch (#623, #401, #…
deaa8b1 
…583, #391)

Make it more consistent with `download`
@soxofaan soxofaan self-assigned this Sep 25, 2024
soxofaan added a commit that referenced this issue Sep 25, 2024
@soxofaan
PR #630 improve save_result handling in VectorCube too (#623, #401, #583
855a4ca 
, #391)
soxofaan added a commit that referenced this issue Sep 25, 2024
@soxofaan
Improve auto-adding of save_result (#623, #401, #583, #391)
d63d93b 
- Check whole process graph for pre-existing `save_result` nodes, not just final node
- Disallow ambiguity of combining explicit `save_result` and download/create_job with format
soxofaan added a commit that referenced this issue Sep 25, 2024
@soxofaan
PR #630 better "weak" format handling in execute_batch (#623, #401, #…
6eaa2d8 
…583, #391)

Make it more consistent with `download`
soxofaan added a commit that referenced this issue Sep 25, 2024
@soxofaan
PR #630 improve save_result handling in VectorCube too (#623, #401, #583
a032416 
, #391)
soxofaan added a commit that referenced this issue Sep 25, 2024
@soxofaan
PR #630 improve save_result handling in VectorCube too (#623, #401, #583
862bfe4 
, #391, #278)
@soxofaan
Copy link
Member

done with 58f0205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soxofaan soxofaan

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soxofaan @jdries