Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue259 allow epsg code as string #453

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Issue259 allow epsg code as string #453

merged 9 commits into from
Aug 8, 2023

Conversation

JohanKJSchreurs
Copy link
Contributor

Implements #259

soxofaan
soxofaan reviewed Jul 31, 2023
View reviewed changes
openeo/util.py Outdated Show resolved Hide resolved
@JohanKJSchreurs JohanKJSchreurs marked this pull request as ready for review August 1, 2023 07:49
@jdries
Copy link
Collaborator

jdries commented Aug 1, 2023

fine for me!

@JohanKJSchreurs JohanKJSchreurs marked this pull request as draft August 1, 2023 11:39
@JohanKJSchreurs
Copy link
Contributor Author

Have found out that we should also support PROJJSON. Adding some test coverage for that as well.

See also:
Open-EO/openeo-processes#58
Open-EO/openeo-processes@2684dab

@JohanKJSchreurs JohanKJSchreurs marked this pull request as ready for review August 1, 2023 13:13
@JohanKJSchreurs JohanKJSchreurs mentioned this pull request Aug 4, 2023
Closed
@jdries jdries merged commit 49be917 into master Aug 8, 2023
16 checks passed
@jdries jdries deleted the issue259_allow-epsg-code-as-string branch August 8, 2023 08:52
@soxofaan soxofaan mentioned this pull request Aug 8, 2023
Closed
soxofaan added a commit that referenced this pull request Aug 9, 2023
@soxofaan
Issue #259/#453#458 finetune crs normalization some more
b2a0e00 
- rename to `normalize_crs` because it is not only about EPSG output, WKT2 output is also allowed
- reworked and simplified pyproj availability handling: when available: use it fully, when not: do best effort normalization
- Move tests into class for better grouping and overview
- add test coverage for "no pyproj available" code path
soxofaan added a commit that referenced this pull request Aug 9, 2023
@soxofaan
Issue #259/#453/#458 Fixup pyproj related test skips
cf57056 
Skip based on pyproj version iso python version
(allows testing the skips on higher python versions too)
soxofaan added a commit that referenced this pull request Aug 9, 2023
@soxofaan
fixup! Issue #259/#453/#458 Fixup pyproj related test skips
49f6c26
soxofaan added a commit that referenced this pull request Aug 25, 2023
@soxofaan
Issue #460/#259/#453/#458 test requirement pyproj>=3.2.0
492c637
soxofaan added a commit that referenced this pull request Aug 25, 2023
@soxofaan
fixup! Issue #460/#259/#453/#458 test requirement pyproj>=3.2.0
0f739f4
soxofaan added a commit that referenced this pull request Aug 25, 2023
@soxofaan
Issue #460/#259/#453/#458 test requirement pyproj>=3.2.0
3e8ecd6
soxofaan added a commit that referenced this pull request Aug 28, 2023
@soxofaan
Issue #460/#259/#453/#458 test requirement pyproj>=3.2.0
316f2b4
soxofaan added a commit that referenced this pull request Aug 28, 2023
@soxofaan
Issue #460/#259/#453/#458 test requirement pyproj>=3.2.0
a546762
soxofaan added a commit that referenced this pull request Aug 28, 2023
@soxofaan
Issue #460/#259/#453/#458 test requirement pyproj>=3.2.0
9b61d0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan soxofaan left review comments

@jdries jdries Awaiting requested review from jdries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohanKJSchreurs @jdries @soxofaan