Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phase out ZKJobRegistry #244

Merged
merged 15 commits into from
Jan 18, 2024
Merged

phase out ZKJobRegistry #244

merged 15 commits into from
Jan 18, 2024

Conversation

bossie
Copy link
Collaborator

@bossie bossie commented Jan 5, 2024

@bossie bossie linked an issue Jan 5, 2024 that may be closed by this pull request
phase out ZkJobRegistry Open-EO/openeo-geopyspark-driver#632
Closed
@bossie bossie marked this pull request as ready for review January 10, 2024 11:06
bossie
bossie commented Jan 10, 2024
View reviewed changes
Copy link
Collaborator Author

@bossie bossie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the naming of openeo_driver.jobregistry.JobRegistryInterface.set_results_metadata; it's ultimately called by JobTracker upon completion of a job.

openeo_driver/jobregistry.py Outdated Show resolved Hide resolved
@bossie bossie requested a review from soxofaan January 10, 2024 11:16
@bossie
TODO re: just_log_errors was addressed
45f3368 
Open-EO/openeo-geopyspark-driver#632
@bossie
list_active_jobs max_age defaults to: all ages
a8fe13d 
But not in the CLI.

Open-EO/openeo-geopyspark-driver#632
@bossie
limit trackable jobs to those with an application_id
f1826aa 
Mirrors ZK implementation introduced in Open-EO/openeo-geopyspark-driver@79340e9.

Open-EO/openeo-geopyspark-driver#632
@bossie
allow this to be referenced by openeo-geopyspark-driver PR
702884b 
To be reverted!

Open-EO/openeo-geopyspark-driver#632
@bossie
fixup! allow this to be referenced by openeo-geopyspark-driver PR
847a3f7 
To be reverted!

Open-EO/openeo-geopyspark-driver#632
@bossie
fixup! fixup! allow this to be referenced by openeo-geopyspark-driver PR
3e20abd 
To be reverted!

Open-EO/openeo-geopyspark-driver#632
@bossie
fixup! fixup! fixup! allow this to be referenced by openeo-geopyspark…
ac39040 
…-driver PR

To be reverted!

Open-EO/openeo-geopyspark-driver#632
@bossie
Copy link
Collaborator Author

bossie commented Jan 17, 2024 •
edited
Loading

TODO:

  • revert package name temporarily changed to be able to reference it in the corresponding openeo_geopyspark build,
  • re-enable tests temporarily skipped,
  • restore upload_dev_wheels to false.

bossie
bossie commented Jan 17, 2024
View reviewed changes
Copy link
Collaborator Author

@bossie bossie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert stuff temporarily introduced to get the entire thing to build.

Jenkinsfile Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
tests/test_server.py Outdated Show resolved Hide resolved
tests/test_views.py Outdated Show resolved Hide resolved
soxofaan
soxofaan approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from some small notes, this PR mainly adds new APIs, leaving original logic basically alone, so looks fine to me

openeo_driver/_version.py Outdated Show resolved Hide resolved
openeo_driver/jobregistry.py Outdated Show resolved Hide resolved
openeo_driver/jobregistry.py Show resolved Hide resolved
openeo_driver/jobregistry.py Show resolved Hide resolved
openeo_driver/jobregistry.py Outdated Show resolved Hide resolved
@bossie bossie merged commit ede6064 into master Jan 18, 2024
@bossie bossie deleted the 632-phase-out-zkjobregistry-1 branch January 18, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan soxofaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

phase out ZkJobRegistry
2 participants
@bossie @soxofaan