Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 401 if no token #84

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Conversation

clausmichele
Copy link
Member

Solves #82

Previously if an user was not authenticated and was requesting /jobs an error was produced and no proper json error message returned.

@pierocampa pierocampa requested a review from aljacob July 13, 2023 13:58
@pierocampa pierocampa self-assigned this Jul 13, 2023
@pierocampa pierocampa added the bug Something isn't working label Jul 13, 2023
Copy link
Member

@pierocampa pierocampa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then we should not catch null pointers (a runtime non-checked exception), but rather avoid them at the root.
So just leave the generic Exception for now, and handle the case where the returned token is null. Then we're done! ; )

@pierocampa pierocampa merged commit b23781b into master Jul 18, 2023
1 check passed
@pierocampa pierocampa deleted the bugfix/82-jobs-does-not-return-json branch July 18, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants