Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About the color of the flashlight #386

Closed
RuffaloLavoisier opened this issue May 14, 2024 · 2 comments
Closed

About the color of the flashlight #386

RuffaloLavoisier opened this issue May 14, 2024 · 2 comments
Assignees
@RuffaloLavoisier
Labels
src/osw-app This PR / issue impacts the current release of the OS

Comments

@RuffaloLavoisier
Copy link
Member

open-smartwatch-os/src/apps/tools/OswAppFlashLight.cpp

Line 36 in 0607210

this->hal->gfx()->fillCircle(120, 120, 115, ui->getForegroundColor());

Always, I think FlashLight recommended Color: White.

becauze FlashLight Color change from configuration setting.
@RuffaloLavoisier
Copy link
Member Author

@Open-Smartwatch/osw-support
How about you?

@simonmicro
Copy link
Member

Yes. Absolutely! This should be fixed to white!

@simonmicro simonmicro added 🐞 bug Something isn't working src/osw-app This PR / issue impacts the current release of the OS and removed 🐞 bug Something isn't working labels May 19, 2024
RuffaloLavoisier added a commit that referenced this issue May 19, 2024
@RuffaloLavoisier
Fixed #386, color for flashLight
f66b7ea 
- white color, and black color
@RuffaloLavoisier RuffaloLavoisier mentioned this issue May 19, 2024
Merged
simonmicro added a commit that referenced this issue May 19, 2024
@simonmicro
Fixed #386, color for flashLight (#389)
173e567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RuffaloLavoisier RuffaloLavoisier

Labels
src/osw-app This PR / issue impacts the current release of the OS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonmicro @RuffaloLavoisier