Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @nestjs/axios version #710

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Fix @nestjs/axios version #710

merged 2 commits into from
Jul 18, 2023

Conversation

daniel-shuy
Copy link
Contributor

@nestjs/axios 0.0.8 has a peer dependency on @nestjs/common ^7.0.0 || ^8.0.0 (https://github.com/nestjs/axios/blob/0.0.8/package.json#L49), but @openapitools/openapi-generator-cli depends on @nestjs/common 9.3.11, which fails strict peer dependency checks (e.g. NPM's --strict-peer-deps or PNPM's strict-peer-dependencies).

@nestjs/axios 0.1+ supports @nestjs/common ^9.0.0 (https://github.com/nestjs/axios/blob/0.1.0/package.json#L49).

3.0.0 is the latest version of @nestjs/axios that still supports @nestjs/common 9.3.11, and meets all the other peer dependencies (https://github.com/nestjs/axios/blob/3.0.0/package.json#L48).

@wing328
Copy link
Member

wing328 commented Jul 13, 2023

thanks for the PR but the CI failed: https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/5529892048/jobs/10115444160?pr=710

can you please take a look when you've time?

@daniel-shuy
Copy link
Contributor Author

daniel-shuy commented Jul 14, 2023

Oops sorry I edited the package.json using the GitHub web editor, but I forgot I needed to run yarn install to update yarn.lock. I've updated yarn.lock with the same version of yarn used by the GitHub Actions (1.22.19)

@wing328
Copy link
Member

wing328 commented Jul 14, 2023

that's ok. thanks again for the PR.

but the build failed: https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/5550379469/jobs/10138303847?pr=710

can you please take a look when you've time?

@nestjs/axios 0.0.8 has a peer dependency on @nestjs/common ^7.0.0 || ^8.0.0
@daniel-shuy
Copy link
Contributor Author

Sorry, turns out the tests are not compatible with axios 1.x.x. I've upgraded the version of @nestjs/axios to 0.1.0 instead, which depends on axios 0.27.2. The build should succeed now

@wing328
Copy link
Member

wing328 commented Jul 18, 2023

thanks for the PR. let's give it a try

@wing328 wing328 merged commit c9c18c8 into OpenAPITools:master Jul 18, 2023
3 checks passed
@daniel-shuy daniel-shuy deleted the patch-1 branch July 18, 2023 04:04
@github-actions
Copy link

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants