Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to put cibuildwheel test or extras config in pyproject.toml #126

Closed
dstansby opened this issue Apr 23, 2023 · 2 comments · Fixed by #127
Closed

Not possible to put cibuildwheel test or extras config in pyproject.toml #126

dstansby opened this issue Apr 23, 2023 · 2 comments · Fixed by #127

Comments

@dstansby
Copy link
Contributor

Because the publish workflow specifies the follwing environment variables:

CIBW_TEST_EXTRAS: ${{ inputs.test_extras }}
CIBW_TEST_COMMAND: ${{ inputs.test_command }}

it's not possible to instead configure these cibuildwheel options in a pyproject.toml file, because not setting these inptus sets the environment variables to empty strings, which overrides pyproject.toml configuration.

Possible solutions:

  • Only set these environment variables if the inputs are given to the action
  • Remove these variables, and instead tell users to use pyproject.toml to configure cibuildwheel. This would be breaking, but I think with a major version bump of the action fine.
@ConorMacBride
Copy link
Member

Similar to #77. I think the first option should be possible. The environment variables can be conditionally set in a new workflow job step just before the cibuildwheel step.

@Cadair
Copy link
Member

Cadair commented May 9, 2023

Picking up on #127 (comment) I wonder if we should make the sdist action be able to read its config from pyproject.toml then we wouldn't need these vars at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants