Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set CIBW testing env vars if workflow input is given #127

Merged
merged 1 commit into from
May 9, 2023

Conversation

ConorMacBride
Copy link
Member

Check if the test_extras or test_command workflow inputs are given, and only set the CIBW environment variables if they are. Therefore cibuildwheel can fall back to configuration in
pyproject.toml.

Closes #126

@ConorMacBride
Copy link
Member Author

Most projects will still need to set the test_extras and test_command inputs for the sdist build anyway. I wonder if people would expect their pyproject.toml cibuildwheel config to override the workflow inputs? In any case, I think checking pyproject.toml configuration would overcomplicate this workflow, and this fix is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to put cibuildwheel test or extras config in pyproject.toml
2 participants