BugFix: Checks to populate matrix input to Newman's app were reversed #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
Only half of the direction pairs of the WAMIT mean drift files are needed to use Newman's approximation, as the other pairs can be obtained by symmetry. However, the checks used to exploit this symmetry and populate the whole matrix were reversed, and this is fixed by this pull request.
Related issue, if one exists
#1096
Impacted areas of the software
HydroDyn (only when Newman's approximation is used)
Additional supporting information
Test results, if applicable
I may be mistaken, but there are currently no tests using Newman's approximation.