Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Fix typo in DLLEXPORT attributes for IfW C interface #1144

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

pablo-benito
Copy link
Contributor

Feature or improvement description

Compilation fix under Windows + GCC (IfW_C_Binding.f90)
The DLLEXPORT attribute in the compiler directives must match the subroutine names, otherwise the compiler throws an error

Related issue, if one exists

Pull request #720

Impacted areas of the software

Additional supporting information

Test results, if applicable

The names of the DLLEXPORT attribute must match the subroutine name
Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I'm not sure how this was missed originally.

@rafmudaf rafmudaf changed the title Compilation fix under Windows + GCC (IfW_C_Binding.f90) BugFix: Fix typo in DLLEXPORT attributes for IfW C interface Jun 1, 2022
@rafmudaf rafmudaf merged commit fd55498 into OpenFAST:dev Jun 1, 2022
@rafmudaf
Copy link
Collaborator

rafmudaf commented Jun 1, 2022

Thank you @pablo-benito!

@rafmudaf rafmudaf added this to the v3.2.0 milestone Jun 1, 2022
@pablo-benito pablo-benito deleted the IfW_C_Binding_fix branch June 1, 2022 19:14
@rafmudaf rafmudaf mentioned this pull request Jul 8, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants