NWTC Library and WriteOutput updates #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires removing the definition of OutStrLenM1 from all the Matlab-generated writeOutput code. But, it also allows that matlab-generated code to be simplified also removed some unused variables
…ation warning C4028: formal parameter 7 different from declaration
This will cause conflict with SeaState branch, but can be ignored there.
rafmudaf
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
This PR moves the
OutStrLenM1parameter andFindValidChannelIndxfunction out of the auto-generated code from the MatlabToolbox for processing OutList variables (WriteOutput) and moves it into NWTC Library. This was done to help simplify some of the code in HydroDyn and its submodules (from #1008). I didn't yet update all the modules' auto-generated code to callFindValidChannelIndx(); that can be done later when the modules' output channels change.Also in this PR:
constto the header.GetWordssubroutine to optionally output the number of words actually read. There were two places in the HD code that tried to calculate the number again outside the routine.ReadOutputListFromFileInforoutine.Test results, if applicable
This does not change any test results.