CI: exclude bokeh 3.0.[0-3] -- broken plots #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokeh 3.0.4 should in theory fix this (bokeh/bokeh#12653). See bug report here: bokeh/bokeh#12614
|
To check the artifacts were working correctly, I made a temporary turned off the waves in the
After testing, the temporary commit was removed from this PR. |
andrew-platt
force-pushed
the
b/TestingPlots
branch
from
b30aa29
to
674c150
Compare
deslaughter
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Bokeh v 3.0.[0-3] had a bug that caused embedded bokeh plots to have a 0x0 size. This showed up in error plots from ctest.
With bokeh 3.0.2:
Correctly displays with bokeh 2.4.3:
Above figures from local testing.
Related issue, if one exists
Related to bokeh bug bokeh/bokeh#12614 which is fixed in the bokeh dev with bokeh/bokeh#12653 (v3.0.4 to be released)
Impacted areas of the software
This was causing plots from automated testing (using
CTEST_PLOT_ERRORS=Onto not display for channels that did not match.Test results, if applicable
This was tested locally. Will run a sanity check on GH actions with a test commit that will throw away.