BeamDyn driver visualization, and bugfix #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fun visualization from BD driver of the bug with the TransDisp. |
deslaughter
approved these changes
Mar 2, 2023
michaelasprague
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
TranslationDispwas not set during initialization. This caused the blade root to "jump" at the first timestep if theGlbRotBladeT0is set toFwith a non-identity DCM and a non-zeroGlbPosvector. This required really tiny timesteps and led to huge transients.Related issue, if one exists
None.
Impacted areas of the software
BeamDyn driver only. This does not affect anything in the coupling to OF.
Additional supporting information
Visualization of blade set to 90 degrees azimuth. Before the fix of the
TranslationDispbug, initialization started with the root at the reference location:After first timestep; note the huge shape change as a result of the sudden jump of the root from (0,0,10) to (0,-10,0):
Test results, if applicable
The GlbRotBladeT0 flag in the bd_5MW_dynamic_gravity_Az90 test case is now set to
Falseto test theTranslationDispbug. The test result is identical to before (as is expected).