Allow up to 99 output planes in FAST.Farm #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pdoubraw, this PR may be of interest to you. |
jjonkman
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Looks good to me. Thanks for making this change.
Just one comment: Can you also change the FAST.Farm documentation (change 9 to 99 in the following section: https://openfast.readthedocs.io/en/main/source/user/fast.farm/InputFiles.html#visualize?
Thanks,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for merging
Feature or improvement description
Previously we only allowed 9 output planes from the low resolution domain in FAST.Farm. Users typically want more planes than this, so they've had to rerun the simulation with a different output plane set to get more planes. This was both time consuming and annoying.
This PR bumps that limit up to 99 planes. If more are required, it would be relatively trivial to bump this limit up to 999 or more.
Related issue, if one exists
None. Just user complaints directly to me.
Impacted areas of the software
FAST.Farm outputs only
Additional supporting information
See plot that @rthedin will add below.
Test results, if applicable
No test results are changed. @rthedin is testing with a large turbine array and will report below if it works as expected.