InflowWind Update / restructure #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FlowField module provides a generic way to represent Uniform, Full-Field, User, and External wind data. This module is part of the effort to provide Inflow data to AeroDyn and HydroDyn via pointers instead of calling InflowWind.
This module allows InflowWind to read wind data files into the new FlowField module data structure in NWTC_Library. In the future, the routines within this module will replace the other InflowWind modules.
Minimal code changes to InflowWind_Init so it can initialize the FlowField data structure in parallel its normal init. This supports comparing output using the driver.
This commit adds routines to calculate flow field derivatives for UniformField and GridField. It also adds a method to calculate smooth velocity and acceleration (in time) for the UniformField. This is a significant improvement over the constant acceleration previously implemented.
This commit adds a flow field type specific initialization section. Currently only used for calculating acceleration when requested.
This commit adds a smooth interpolation function for the FlowField GridField type which gives velocity and acceleration based on cubic hermite spline interpolation. An external grid field type was added to satisfy the 4Dext type from InflowWind.
Changes to InflowWind to support addition of FlowField types
Needed to simplify the routine a bit for adding the GridExceedence options
Only applies to OLAF free wake points.
This gives a reasonably continuous function (not smooth) from the tower out beyond the +/-Y edge of the grid. There is some physics that we can't account for simply because the information doesn't exist, but this should at least allow wake evolution. If weirdness occurs, extend grid to ground. One missing piece at the moment is the summation of NGe should be ==1 for the region between 2*FFYHWid < abs(y) < FFYHWid, but it is not. Since the plots show continuity in value (not in derivatives), it is assumed there is some book-keeping incorrect with the NGe(5) and NGe(10) terms which get multiplied by zero. So something isn't exactly right in the derivation, but the result is still reasonable (though potentially incorrect).
Missed a corner case
The tolerance check for the bottom edge of the grid should be scaled to match the other tolerance specs
Also removed all redundant modules.
- lines swapped in Uniform_to_Grid3D - array dims swapped in Uniform_to_Grid3D - check for Z==0 in Uniform_to_Grid3D - array dims swapped in Grid3D_to_Uniform - fix real types in Grid3D_WriteBladed - fix swapped lines in Grid3D_WriteVTK which caused a nested directory to be created for each file (bug in existing code)
andrew-platt
reviewed
Apr 7, 2023
andrew-platt
reviewed
Apr 7, 2023
andrew-platt
reviewed
Apr 7, 2023
Needed to have BoxExceed in the driver input file for regression testing Added acceleration to Points.Velocity.dat output file for regression testing.
andrew-platt
approved these changes
Apr 7, 2023
andrew-platt
added a commit
that referenced
this pull request
Apr 18, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
This pull request contains the following changes to InflowWind:
FlowFieldTypewhich contains and represents all wind types.FlowFieldTypesupporting functions to:FlowFieldTypeInflowWindinput file (VelCubicInterp) to optionally calculate accelerations and use cubic spline interpolation for velocities.INVALID.InflowWind_CalcOutputto use new methods and structuresFAST.Farmto useFlowFieldTypeRelated issue, if one exists
Impacted areas of the software
InflowWindFAST.Farm(renamed a variable)Additional supporting information
Test results, if applicable
All unit and regression tests are currently passing. This pull request adds three new regression tests for InflowWind:
Points.Velocity.datfile)