[Bugfix] InflowWind: using derived types to read wind file headers failed when using ifort. #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Bug description
InflowWind did not read the wind file header data correctly when compiled with the Intel Fortran (ifort) compiler.
Impacted areas of the software
InflowWind_IO.f90Additional supporting information
When InflowWind was refactored, the new code made use of derived types to read file header information for TurbSim and Bladed wind files. This allowed multiple variables to be read at one time and simplified the code. However, when compiled with ifort this read did not populate the derived type correctly due to the assumption of padding between the members of the type. GFortran did not have this issue. The solution was to add the
SEQUENCEstatement to the derived types indicating that the members should be considered without padding.Test results, if applicable
InflowWind tests are passing when compiled with ifort and Visual studio 17 on Windows.