FF: fix bug with Mod_AmbWind=3 -- hub point wasn't shifted. #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added the hub point to AWAE at the center of the grid now that IfW calculates the disk average velocity every time IfW_CalcOutput gets called. But this point needs to be shifted by the turbine position so it is in the box. This will all change in 4.0.0 when we switch to pointers for all this and don't call IfW_CalcOutput directly anymore.
deslaughter
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for merging.
Feature or improvement description
In v3.5.0 we added the hub point to AWAE at the center of the grid now that IfW calculates the disk average velocity every time IfW_CalcOutput gets called. But this point needs to be shifted by the turbine position so it is in the box.
This will all change in 4.0.0 when we switch to pointers for all this and don't call IfW_CalcOutput directly anymore.
Related issue, if one exists
See comment 2 and discussion in #1615 here: #1615 (comment)
Impacted areas of the software
The
ModAmbWind=3option in FAST.Farm should in theory now work correctly.Additional supporting information
In v4.0.0, this will all be changed. So for now we will keep the calculations of disk average velocity in the InflowWind_CalcOutput routine.
Test results, if applicable
No test results change. We don't currently have a
Mod_AmbWind=3FAST.Farm test case. This would have been caught by it.