IfW: Bug Fix: compute vel avg profile when exceed allowed #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebranlard
changed the title
|
Good enough solution for now :). Thanks for addressing this! |
|
@ebranlard Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ready to be merged
Feature or improvement description
When using OLAF, VelAvg was not computed, and box extrapolation using VelAvg would result in access violations.
Related issue, if one exists
#1746
Impacted areas of the software
InflowWind, OLAF
Additional supporting information
We could also implement periodic boundary conditions (for lateral extent) instead of using the average profile.