-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environmental variables to driver input files #707
Add environmental variables to driver input files #707
Conversation
The changes looks good to me. I'm not sure what the difference between MHK fixed and MHK floating would imply and if this distinction is needed for the driver. |
Thanks, Emmanuel. The difference between fixed and floating is in how the coordinate system is handled, since a floating system will have its base above its tower. We will likely need this distinction for the driver so we can properly calculate submergence depth for both cases. We haven't implemented the floating case yet, so if it turns out the distinction is not needed, we can remove it later on. |
98707b7
to
1d84d90
Compare
Move environment vars for HD init into InitInpType
@rafmudaf @andrew-platt @ebranlard This pull request is ready to merge, pending review and a final run of the regression tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good to me.
I've noticed that WtrDens
was changed from SiKi to ReKi in the Waves module. This could potentially change results. An alternative would be to keep it as SiKi
, and then do a type conversion when this variable is set ( wave%WtrDens = real( input%WtrDens , SiKi )
) .
@andrew-platt Do you have a preference on how this is done? |
If all the other variables are handled as I don't have a strong opinion either way. |
Thanks, @ebranlard and @andrew-platt. I will make the suggested change. |
Codecov Report
@@ Coverage Diff @@
## dev #707 +/- ##
==========================================
+ Coverage 11.29% 11.30% +0.01%
==========================================
Files 211 211
Lines 310557 310787 +230
Branches 181045 178127 -2918
==========================================
+ Hits 35068 35137 +69
- Misses 231395 231510 +115
- Partials 44094 44140 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@rafmudaf @ebranlard @andrew-platt All of the tests are now passing, so this pull request is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the input file changes for the main .fst file listed in the docs/source/user/api_change.rst
. Could you add a couple lines there in the first table with the input file changes?
@andrew-platt Done! |
This pull request is ready to be merged.
Feature or improvement description
This pull request adds environmental variables to the AeroDyn, HydroDyn, and OpenFAST driver input files. Environmental variables in the AeroDyn and HydroDyn primary input files now have a "default" option. If set to "default", values are read in from the driver files. Otherwise, driver values are overwritten. An "MHK" switch is also added to the AeroDyn and OpenFAST driver input files to allow either AirDens or WtrDens to be read in as the density of the primary working fluid. For now, an error is thrown if the MHK switch is activated.
Impacted areas of the software
Test results
All regression tests have been updated and pass.
Check list