[BugFix] Fix C++ API for restart, Error handling in FAST Library, and AeroDyn echo file lock #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafmudaf
changed the title
andrew-platt
approved these changes
Apr 12, 2021
Related to comment at the end of OpenFAST#695 AD was overwriting the echo file unit number when opening the blade properties files, which caused the echo file not to be closed when exiting the routine.
bjonkman
changed the title
Drag term for axial induction was written twice instead of once for axial and once for tangential.
This should remove the "-dirty" from Simulink builds on bjonkman fork (for now)
This should be called ONLY in projects that use VersionInfo.f90 because it isn't used elsewhere.
rafmudaf
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR fixes a few minor bugs:
AIDragwas listed twice andTIDragwas omitted).Related issue, if one exists
The size of the restart arrays is similar to the fix in #702
The AD echo file lock was reported in #695
Impacted areas of the software
Test results, if applicable
This will not change any existing tests because restart and the Simulink interface are not currently tested here.