Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some memory leaks in FAST.Farm #860

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

bjonkman
Copy link
Contributor

@bjonkman bjonkman commented Oct 7, 2021

This pull request is ready to merge.

Feature or improvement description
I modified FAST_Farm_Subs.f90 to avoid some memory leaks. These changes should not affect any results.

Related issue, if one exists
These issues were found in #784, but may or may not have solved the underlying problem there.

Impacted areas of the software
FAST.Farm

1. AWAE_End was never called, so some memory wasn't getting deallocated from InflowWind

2. Many of the "farm" variables were not deallocated

3. I made the OutList(:) array in FAST.Farm a fixed size instead of allocatable. It was getting allocated to a fixed size (set by parameter) anyway.
Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks!

@andrew-platt andrew-platt self-assigned this Oct 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #860 (7943191) into dev (7a59bec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #860   +/-   ##
=======================================
  Coverage   11.27%   11.27%           
=======================================
  Files         211      211           
  Lines      309733   309733           
  Branches   180530   180530           
=======================================
  Hits        34910    34910           
  Misses     230900   230900           
  Partials    43923    43923           
Flag Coverage Δ
regtests 11.16% <ø> (ø)
unittests 2.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
modules/nwtc-library/src/NWTC_IO.f90 26.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a59bec...7943191. Read the comment docs.

@andrew-platt andrew-platt merged commit 9cdd272 into OpenFAST:dev Oct 7, 2021
@bjonkman bjonkman deleted the b/FAST.Farm-memory branch October 7, 2021 21:28
@rafmudaf rafmudaf mentioned this pull request Mar 2, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants