Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TurbSim modifications #887

Merged
merged 26 commits into from
Jul 8, 2022
Merged

TurbSim modifications #887

merged 26 commits into from
Jul 8, 2022

Conversation

bjonkman
Copy link
Contributor

@bjonkman bjonkman commented Oct 18, 2021

This pull request is ready to be merged AFTER regression test results are updated.

Feature or improvement description

  1. This code removes the Clockwise input from TurbSim. This input variable was intended to compare with different configurations of Bladed; we have determined that Bladed needs the value to always be FALSE, so we have removed this as an input to TurbSim. InflowWind's Bladed-format read routine has been updated so that it does not require the CLOCKWISE flag in the associated summary file.
  2. TurbSim has a new input, WrHAWCFF, to allow it to output full-field turbulence in the HAWC format (i.e., separate files for u, v, and w components). Note that these files are written as the inverse of how OpenFAST/InflowWind reads them in... if it is determined that the HAWC2 files need to be read/written differently, please update both codes so they are consistent.
  3. TurbSim has some changes to the Bladed formatted-full-field wind files:
    • These files are now output using the Bladed left-hand rule convention. This should have no effect when used with InflowWind, but should result in better comparisons between OpenFAST/InflowWind and Bladed. (Note: Bladed will now show its v-component wind speed as the negative of InflowWind's v-component wind speed. HOWEVER, the turbine response matches with this sign change.)
    • The scaling factors for v- and w-component wind speeds have been modified to account for non-zero mean values. This fixes a bug that could be seen with no turbulence but large flow angles.
  4. The TurbSim summary file now contains the git hash from the TurbSim build.
  5. The rotor-equivalent power law exponent displayed in the summary file is now calculated over only the upper rotor disk.
  6. TurbSim now checks that the input files contain real numbers.
  7. The default wind profile type is now PL instead of IEC. (IEC is a hybrid profile type that does not seem very physical.) This will affect simulations where the wind profile type was set to "default" and (1) the reference wind speed was defined at a height outside the assumed rotor diameter, (2) tower points are used, or (3) the grid width is smaller than the grid height.
  8. Example TurbSim input files and a section on the new HAWC-formatted output files are included in the documentation. I think the rest of the TurbSim documentation is being updated elsewhere, so hopefully this doesn't create too many conflicts.
  9. I removed some unnecessary variables in the InflowWind c-binding library.

Impacted areas of the software
TurbSim, InflowWind, documentation

Test results, if applicable
I updated the TurbSim input files in the regression tests and re-ran them. Most of the cases had been using data from TurbSim 1.5.0 and 1.06.0. TurbSim 1.06.0 files will have some differences due to algorithm changes.

This should always be false for comparison to Bladed, and I would like to remove that flag from TurbSim next.
This was added to compare with Bladed, but Bladed reads the same way InflowWind does, too.
THIS CHANGES THE TURBSIM INPUT FILE: DOCUMENT THIS!
- previously calculated the PL by computing values at the top and bottom of the rotor. It now estimates this using the top and hub/reference point. This helps for the wind profiles that might be 0 or slightly negative at the bottom of the rotor, and also seems more consistent with the definition for IEC standards that uses the hub as the reference point.
1. In comparing wind files with Bladed, it was determined that Bladed uses a left-hand rule for the wind velocities. To compare with OpenFAST simulations, we now store the negative of the V component in Bladed files, and make sure to flip the sign again in OpenFAST.

2. With certain wind directions in Bladed files, the V and W components have significant round-off errors, so we added some safety checks to avoid the scaling factors that cause the issue.
also added `alt` keyword to figures to avoid warnings in VSCode previewer
@bjonkman bjonkman changed the title F/inflow clockwise TurbSim modifications Oct 18, 2021
For native Bladed format files, interpolate the turbulent part, then add the mean wind speed (makes for smoother wind profile between grid points)
@rafmudaf rafmudaf added this to the v3.2.0 milestone Apr 7, 2022
@rafmudaf rafmudaf merged commit 3339907 into OpenFAST:dev Jul 8, 2022
@rafmudaf rafmudaf mentioned this pull request Jul 8, 2022
10 tasks
@bjonkman bjonkman deleted the f/Inflow_Clockwise branch July 11, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants