-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TurbSim modifications #887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should always be false for comparison to Bladed, and I would like to remove that flag from TurbSim next.
This was added to compare with Bladed, but Bladed reads the same way InflowWind does, too.
e.g., not Inf or NaN
THIS CHANGES THE TURBSIM INPUT FILE: DOCUMENT THIS!
- previously calculated the PL by computing values at the top and bottom of the rotor. It now estimates this using the top and hub/reference point. This helps for the wind profiles that might be 0 or slightly negative at the bottom of the rotor, and also seems more consistent with the definition for IEC standards that uses the hub as the reference point.
1. In comparing wind files with Bladed, it was determined that Bladed uses a left-hand rule for the wind velocities. To compare with OpenFAST simulations, we now store the negative of the V component in Bladed files, and make sure to flip the sign again in OpenFAST. 2. With certain wind directions in Bladed files, the V and W components have significant round-off errors, so we added some safety checks to avoid the scaling factors that cause the issue.
also added `alt` keyword to figures to avoid warnings in VSCode previewer
For native Bladed format files, interpolate the turbulent part, then add the mean wind speed (makes for smoother wind profile between grid points)
rafmudaf
force-pushed
the
f/Inflow_Clockwise
branch
from
July 8, 2022 14:39
546639e
to
743d235
Compare
rafmudaf
force-pushed
the
f/Inflow_Clockwise
branch
from
July 8, 2022 20:25
743d235
to
fd5d71e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged AFTER regression test results are updated.
Feature or improvement description
Clockwise
input from TurbSim. This input variable was intended to compare with different configurations of Bladed; we have determined that Bladed needs the value to always beFALSE
, so we have removed this as an input to TurbSim. InflowWind's Bladed-format read routine has been updated so that it does not require theCLOCKWISE
flag in the associated summary file.WrHAWCFF
, to allow it to output full-field turbulence in the HAWC format (i.e., separate files for u, v, and w components). Note that these files are written as the inverse of how OpenFAST/InflowWind reads them in... if it is determined that the HAWC2 files need to be read/written differently, please update both codes so they are consistent.PL
instead ofIEC
. (IEC
is a hybrid profile type that does not seem very physical.) This will affect simulations where the wind profile type was set to "default" and (1) the reference wind speed was defined at a height outside the assumed rotor diameter, (2) tower points are used, or (3) the grid width is smaller than the grid height.Impacted areas of the software
TurbSim, InflowWind, documentation
Test results, if applicable
I updated the TurbSim input files in the regression tests and re-ran them. Most of the cases had been using data from TurbSim 1.5.0 and 1.06.0. TurbSim 1.06.0 files will have some differences due to algorithm changes.