-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Boolean queries for BASE #412
Conversation
Thank you! In general this leads to a much better retrieval for complex queries, and allows a better fine tuning of search results.
Likewise, Additionally, it may make sense to add to the documentation that negative keywords should be added with consecutive |
…ain regex to better handle exclusions and or's
Thanks for the thorough review! I updated the regex to cover the problems you described. In addition, I added a preprocessing step that removes unnecessary pluses and minuses. The regex now also deals correctly with multiple parentheses and inverted commas (single and double). Please check again. There is now a test file in /test that provides a number of test cases. |
Thank you very much, I think this is a great improvement. I took liberty to add functionality to the test script, it now makes a comparison between actual and expected results and notifies of errors. |
Thanks, I introduced several changes to the preprocessing to accommodate the queries that did not produce the expected result; as a results, pluses are now always replaced by spaces. I also made sure that phrases are not altered in the preprocessing step to enable the user to force searching for the exact term. Please check again! |
Thank you for the expansion, all tests are now successful. In my view, this is good to go. |
This PR enables all Boolean queries described in the BASE Interface Guide (see section 4 on page 13) in verbatim mode. The changes have been extensively tested, but further tests would be very useful. Examples include: