Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descsize filter to BASE #464

Merged
merged 29 commits into from
Oct 1, 2020
Merged

Add descsize filter to BASE #464

merged 29 commits into from
Oct 1, 2020

Conversation

sckott
Copy link
Collaborator

@sckott sckott commented Aug 18, 2020

  • using latest rbace tag v0.2 on github
  • modify base get_papers to include descsize in fields pulled down
  • modify base get_papers to include the filter parameter passed down to bs_search
  • change base test file to include a descsize filter

use latest rbace tag https://github.com/ropensci/rbace/tree/v0.2.0 remotes::install_github("ropensci/rbace@v0.2.0") or install.packages("rbace", repos = "https://news.ropensci.org")

- using latest rbace tag v0.2 on github
- modify base get_papers to include descsize in fields pulled down
- modify base get_papers to include the filter parameter passed down to bs_search
- change base test file to include a descsize filter
@sckott sckott requested a review from chreman August 18, 2020 19:38
@chreman
Copy link
Member

chreman commented Sep 16, 2020

Additional changes were made so that min_descsize is now an external parameter.

@chreman chreman merged commit e131bab into master Oct 1, 2020
chreman added a commit to chreman/Headstart that referenced this pull request Oct 13, 2021
@chreman chreman deleted the sckott-base-change branch October 14, 2021 12:30
@chreman chreman changed the title base work Add descsize filter to BASE Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants