Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring (List): final step #509

Merged
merged 10 commits into from
Dec 2, 2020
Merged

Refactoring (List): final step #509

merged 10 commits into from
Dec 2, 2020

Conversation

Konstiman
Copy link
Contributor

This PR introduces the last part of the List component refactoring: the transition to a single List component and the legacy code removal.

The new code is now independent of the MODERN_FRONTEND flag: the app always builds with the new code.

Main features:

Redux:

  • New RESIZE action for handling the page resize

Components:

  • The list is now one single component
  • Moved the remaining HTML from the .handlebars to the subcomponents
  • Minor fixes and code improvements
  • Removed warns from the actions triggered by new code

Legacy code:

  • Deleted all of the code that ran conditionally if the modern frontend flag was off
  • Deleted all the list .handlebars templates (they were all refactored into the .jsx templates)

Tests:

  • Since the structure changed, a lot of tests had to be modified

Known bugs:

none yet

@chreman chreman merged commit 945d56d into master Dec 2, 2020
@Konstiman Konstiman deleted the refactoring-list-final branch December 21, 2020 11:52
chreman added a commit to chreman/Headstart that referenced this pull request Oct 13, 2021
…toring-list-final

Refactoring (List): final step

Former-commit-id: 945d56d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants