Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RiftManager creation logic to be a bit more stable by DB config #347

Open
MikeJeffers opened this issue Jun 11, 2021 · 1 comment
Open

Refactor RiftManager creation logic to be a bit more stable by DB config #347

MikeJeffers opened this issue Jun 11, 2021 · 1 comment
Assignees
@radjax1214
Labels
Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation good first issue Good for newcomers Priority: Low This ticket is not part of any forseen need or upcoming roadmap item Refactor Code maintainability, style, or other non-functional changes

Comments

@MikeJeffers
Copy link

https://github.com/OpenPerpetuum/PerpetuumServer/blob/Development/src/Perpetuum.Bootstrapper/PerpetuumBootstrapper.cs#L2423-L2438
and
https://github.com/OpenPerpetuum/PerpetuumServer/blob/Development/src/Perpetuum/Services/RiftSystem/ZoneRiftConfigs.cs#L10-L31
and
https://github.com/OpenPerpetuum/PerpetuumServer/blob/Development/src/Perpetuum/Services/RiftSystem/RiftManager.cs#L71
Could be refactored to only create a RiftManager instance if the ZoneRiftConfig has a non-zero entry for the zone.

Otherwise zones that are not training/stronghold zones will need a 0'd out entry per zone, and will have an update loop that does nothing.
@MikeJeffers MikeJeffers added good first issue Good for newcomers Refactor Code maintainability, style, or other non-functional changes labels Jun 11, 2021
@MikeJeffers
Copy link
Author

For example, relicmanagers are also conditionally initialized and added to the zones IFF they are properly configured with non-zero relics to manage:
https://github.com/OpenPerpetuum/PerpetuumServer/blob/Development/src/Perpetuum.Bootstrapper/PerpetuumBootstrapper.cs#L2456-L2490

@MikeJeffers MikeJeffers added Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation Priority: Low This ticket is not part of any forseen need or upcoming roadmap item labels Oct 29, 2021
radjax1214 added a commit that referenced this issue Nov 1, 2021
@radjax1214
Merge pull request #418 from OpenPerpetuum/PerpetuumServer-RiftManage…
4eac0d2 
…rRefactor-Issue#347

Refactor RiftManager creation logic - (#347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radjax1214 radjax1214

Labels
Difficulty: Easy This issue would be easy to do, and has little uncertainty in scope and implementation good first issue Good for newcomers Priority: Low This ticket is not part of any forseen need or upcoming roadmap item Refactor Code maintainability, style, or other non-functional changes
Projects
Game Server
Status: Checkup
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeJeffers @radjax1214