-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RELEASING.md #363
Merged
Merged
Add RELEASING.md #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-fleming
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Should we add something for announcements?
Comment on lines
+20
to
+21
|
||
(3) Create a release branch and add a tag to it. This branch can be useful if we need to push a hot fix on top of an existing release in the case of a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I don't think so, these guidelines are strictly technical. |
andrew-fleming
pushed a commit
to andrew-fleming/cairo-contracts
that referenced
this pull request
Jun 24, 2022
* add releasing.md * clarify branch role
martriay
added a commit
that referenced
this pull request
Jun 28, 2022
* update access, account, and security tests * update token tests * update proxy, finish proxiable test * update upgradeables and proxy tests * update upgradeble erc20 and tests * update docs * fix sentence * remove comment * remove directives * change definitions to classes * update readme, remove error msg * add assert_revert_entry_point * fix comment * add assert_revert_entry_point * add declaring contracts section * add specificity to declared classes * add assert_revert_entry_point to ToC * fix conflicts * rebase * Add RELEASING.md (#363) * add releasing.md * clarify branch role * update token tests * update proxy, finish proxiable test * update upgradeables and proxy tests * add assert_revert_entry_point * rebase * fix test name * fix mocksigner section * Apply suggestions from code review Co-authored-by: Martín Triay <martriay@gmail.com> * Update docs/Proxies.md Co-authored-by: Martín Triay <martriay@gmail.com> * change 'implementation instance' * fix attribution to v0.2.0 * remove trailing commas * change 'internal' comment * remove unnecessary admin check * fix proxy api Co-authored-by: Martín Triay <martriay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.