Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RELEASING.md #363

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Add RELEASING.md #363

merged 2 commits into from
Jun 21, 2022

Conversation

martriay
Copy link
Contributor

@martriay martriay commented Jun 16, 2022

No description provided.

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should we add something for announcements?

Comment on lines +20 to +21

(3) Create a release branch and add a tag to it. This branch can be useful if we need to push a hot fix on top of an existing release in the case of a bug.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martriay
Copy link
Contributor Author

I don't think so, these guidelines are strictly technical.

@martriay martriay merged commit c4f7083 into main Jun 21, 2022
@martriay martriay deleted the add-releasing branch June 21, 2022 14:04
andrew-fleming pushed a commit to andrew-fleming/cairo-contracts that referenced this pull request Jun 24, 2022
* add releasing.md

* clarify branch role
martriay added a commit that referenced this pull request Jun 28, 2022
* update access, account, and security tests

* update token tests

* update proxy, finish proxiable test

* update upgradeables and proxy tests

* update upgradeble erc20 and tests

* update docs

* fix sentence

* remove comment

* remove directives

* change definitions to classes

* update readme, remove error msg

* add assert_revert_entry_point

* fix comment

* add assert_revert_entry_point

* add declaring contracts section

* add specificity to declared classes

* add assert_revert_entry_point to ToC

* fix conflicts

* rebase

* Add RELEASING.md (#363)

* add releasing.md

* clarify branch role

* update token tests

* update proxy, finish proxiable test

* update upgradeables and proxy tests

* add assert_revert_entry_point

* rebase

* fix test name

* fix mocksigner section

* Apply suggestions from code review

Co-authored-by: Martín Triay <martriay@gmail.com>

* Update docs/Proxies.md

Co-authored-by: Martín Triay <martriay@gmail.com>

* change 'implementation instance'

* fix attribution to v0.2.0

* remove trailing commas

* change 'internal' comment

* remove unnecessary admin check

* fix proxy api

Co-authored-by: Martín Triay <martriay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants