Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Nile version to 0.7.1 #381

Merged
merged 5 commits into from
Jul 26, 2022
Merged

Bump Nile version to 0.7.1 #381

merged 5 commits into from
Jul 26, 2022

Conversation

EvolveArt
Copy link
Contributor

@EvolveArt EvolveArt commented Jul 7, 2022 •
edited
Loading

PR Checklist

  • Change nile dependency
  • Change default max_fee to 1

andrew-fleming
andrew-fleming reviewed Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvolveArt thank you for the PR! Left a couple small questions regarding the proposed fee change if you don't mind taking a look :)

tests/signers.py Outdated Show resolved Hide resolved
@EvolveArt
Copy link
Contributor Author

@EvolveArt thank you for the PR! Left a couple small questions regarding the proposed fee change if you don't mind taking a look :)

You're welcome! Well yes I think so as max fee is enforced to be positive on the protocol layer.
Will apply the change to 'MockSigner' tho

@andrew-fleming
Copy link
Collaborator

You're welcome! Well yes I think so as max fee is enforced to be positive on the protocol layer. Will apply the change to 'MockSigner' tho

Ah gotcha. Sounds good!

@EvolveArt
Copy link
Contributor Author

EvolveArt commented Jul 8, 2022 •
edited
Loading

You're welcome! Well yes I think so as max fee is enforced to be positive on the protocol layer. Will apply the change to 'MockSigner' tho

Ah gotcha. Sounds good!

Should be all good now :)

EDIT: Not sure why the change to MockSigner doesn't work and there seem to be an invalid signature error on every test in test_EthAccount. Looks like it may be linked to the EthAccount contract ?
Was working well with max_fee=0 so this change might just not be needed.

andrew-fleming
andrew-fleming approved these changes Jul 9, 2022
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvolveArt looks great!

Also, I think we'll need to take a deeper look into the max_fee issue with our EthSigner, so thank you for also bringing this up!

@andrew-fleming andrew-fleming mentioned this pull request Jul 12, 2022
Closed
martriay
martriay approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@martriay martriay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a question. We should probably have to bump to 0.7.1 soon given the recent account fix.

tests/signers.py Outdated Show resolved Hide resolved
@martriay martriay mentioned this pull request Jul 13, 2022
Merged
@EvolveArt
Copy link
Contributor Author

EvolveArt commented Jul 13, 2022 •
edited
Loading

Looks good! Left a question. We should probably have to bump to 0.7.1 soon given the recent account fix.

For sure!

@martriay
Copy link
Contributor

martriay commented Jul 13, 2022 •
edited
Loading

Just released Nile 0.7.1 so CI should pass soon.

@martriay
Copy link
Contributor

Nope. Tests are failing 🤔

@EvolveArt
Copy link
Contributor Author

Well Nile 0.7.1 not out yet

@martriay
Copy link
Contributor

martriay commented Jul 13, 2022 •
edited
Loading

Yes it is. I've rerun the jobs twice already. Tests are failing for another reason. I think it's #395.

@martriay martriay added this to the next milestone Jul 15, 2022
@martriay martriay changed the title Change Nile version to 0.7.0 Bump Nile version to 0.7.0 Jul 18, 2022
@martriay martriay changed the title Bump Nile version to 0.7.0 Bump Nile version to 0.7.1 Jul 18, 2022
@andrew-fleming andrew-fleming mentioned this pull request Jul 22, 2022
Merged
@martriay martriay merged commit 7a8effd into OpenZeppelin:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martriay martriay martriay approved these changes

@andrew-fleming andrew-fleming andrew-fleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cairo team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvolveArt @andrew-fleming @martriay