Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Add support for goerli2 and integration testnets #272

Merged
merged 9 commits into from
Nov 2, 2022

Conversation

martriay
Copy link
Contributor

Fixes #271

@martriay martriay requested review from ericnordelo and andrew-fleming and removed request for ericnordelo October 28, 2022 23:05
andrew-fleming
andrew-fleming previously approved these changes Oct 29, 2022
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @martriay! I left a couple small comments :)

src/nile/common.py Outdated Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left a couple of suggestions.

src/nile/cli.py Outdated Show resolved Hide resolved
src/nile/cli.py Outdated Show resolved Hide resolved
src/nile/common.py Outdated Show resolved Hide resolved
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
martriay and others added 4 commits November 1, 2022 23:02
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
Co-authored-by: Eric Nordelo <eric.nordelo39@gmail.com>
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to me!

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@martriay martriay merged commit b4c7fc8 into main Nov 2, 2022
@martriay martriay deleted the support-integration-testnet branch November 2, 2022 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support integration and goerli2 testnets
3 participants