Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Fix account invariant #302

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Fix account invariant #302

merged 2 commits into from
Nov 24, 2022

Conversation

martriay
Copy link
Contributor

@martriay martriay commented Nov 23, 2022

Fixes #301. This PR also fixes max_fee, which was being passed to starknet_cli as an array instead of a number:

['1', '2', '3', '4'] instead of 1234

Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@martriay
Copy link
Contributor Author

i think we should release this as a patch asap cc/ @ericnordelo

Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@martriay martriay merged commit 98ce378 into main Nov 24, 2022
@martriay martriay deleted the fix-invariant branch November 24, 2022 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account invariant can be broken
3 participants