Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/solc 0.7.4 warnings #2391 #2396

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Fix/solc 0.7.4 warnings #2391 #2396

merged 3 commits into from
Oct 28, 2020

Commits on Oct 28, 2020

  1. Fix unnamed return variable warning 

    This commit fixes warnings thrown by the solc 0.7.4 compiler:
"Warning: Unnamed return variable can remain unassigned. Add an explicit
return with value to all non-reverting code paths or name the variable."
    @zemse
    zemse committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    e871373 View commit details
    Browse the repository at this point in the history

  2. Fix function state mutability warning 

    This commit fixes warnings thrown by the solc 0.7.4 compiler:
"Warning: Function state mutability can be restricted to pure"
    @zemse
    zemse committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    a79aa29 View commit details
    Browse the repository at this point in the history

  3. Fix shadows an existing declaration warning 

    This commit fixes warnings thrown by the solc 0.7.4 compiler:
"Warning: This declaration shadows an existing declaration."

1. Arguments by default are not underscored.
2. If the name isn't available due to shadowing, use prefix underscore.
3. If prefix underscore isn't available due to shadowing, use suffix underscore.
    @zemse
    zemse committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    106be12 View commit details
    Browse the repository at this point in the history