Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Context._msgData return "bytes calldata" #2492

Merged
merged 4 commits into from
Jan 29, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 29, 2021

Fixes #2475

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx
Copy link
Collaborator Author

Amxx commented Jan 29, 2021

@frangio, do you think this needs particular documentation ?

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Amxx Amxx changed the title making Context._msgSender return "bytes calldata" making Context._msgData return "bytes calldata" Jan 29, 2021
@frangio frangio changed the title making Context._msgData return "bytes calldata" Make Context._msgData return "bytes calldata" Jan 29, 2021
@frangio frangio merged commit 03832c1 into OpenZeppelin:solc-0.8 Jan 29, 2021
@Amxx Amxx deleted the refactor/msgSenderCalldata branch January 29, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants