Annotate Multicall contract #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
previously approved these changes
Jan 16, 2023
|
Let's update the changelog for this one so if someone has added |
frangio
previously approved these changes
Jan 18, 2023
frangio
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3843
Annotates
MulticallUpgradeablewith@custom:oz-upgrades-unsafe-allow delegatecallso that Upgrades Plugins will not raise a validation error for the delegatecall. Note that the Upgrades Plugins will still perform validations to ensure that the contract does not have selfdestructs.PR Checklist